Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript's new moduleResolution breaks errlop's typing #196

Closed
kwasimensah opened this issue Aug 16, 2022 · 3 comments
Closed

Typescript's new moduleResolution breaks errlop's typing #196

kwasimensah opened this issue Aug 16, 2022 · 3 comments

Comments

@kwasimensah
Copy link

See microsoft/TypeScript#49160 . Typescript's new moduleResolution type doesn't look at the top-level types field in your package.json (it now uses the logic specified in https://www.typescriptlang.org/docs/handbook/esm-node.html#packagejson-exports-imports-and-self-referencing)
@balupton
Copy link
Member

Same deal as bevry/istextorbinary#270

@balupton
Copy link
Member

Boundation successfully updated this package and didn't encounter this error. Is it still a problem for you?

@balupton balupton mentioned this issue Nov 19, 2023
Closed
@balupton
Copy link
Member

balupton commented Nov 21, 2023 •
edited
Loading

this should be resolved with v7.3.0
3071fb2#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

shoutout to my GitHub Sponsors for affording me the time to make this happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@balupton @kwasimensah