Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specification not being added #227

Closed
markbes1 opened this issue Oct 2, 2024 · 10 comments
Closed

Specification not being added #227

markbes1 opened this issue Oct 2, 2024 · 10 comments
Assignees
Labels
bug This is not working as expected done Done, but not yet deployed in QA-System on pilot This one is available in Q-System and ready for testing on production This one is available on P-System P0: critical We need this one before yesterday

Comments

@markbes1
Copy link
Collaborator

markbes1 commented Oct 2, 2024

Current behavior

When lab request is added from Tamanu the specification is not being added for sample in SENAITE

Expected behavior

Specification should get added automatically based on sample type of the request

Screenshot (optional)

@markbes1 markbes1 added bug This is not working as expected P0: critical We need this one before yesterday labels Oct 2, 2024
@xispa
Copy link
Collaborator

xispa commented Oct 3, 2024

This is really strange, we have not changed anything related with the auto-assignment of specifications on sample creation. Can you please confirm this is happening after Tamanu was updated? (I am curious to know if there was any change regarding to the specimen type resource). Also, please provide the link to the affected sample(s) from the production site so I can check in-situ.

@markbes1
Copy link
Collaborator Author

markbes1 commented Oct 3, 2024

I can't access the site now but lab says it's all samples coming from Tamanu no change to sample types with Tamanu upgrade that I'm aware of

@markbes1
Copy link
Collaborator Author

markbes1 commented Oct 3, 2024

Here are examples where specification didn't get added BSE24W735, BSE24W639, BU24W620
EDTA looks to be working but serum and urine are not also no specification being added automatically when registering samples manually

@markbes1
Copy link
Collaborator Author

@xispa this is also not working on Palau P and Q systems and Nauru Q system.
Note after sample type is assigned no specification shows to be added manually when clicking on specification box but before assigning sample type all show when clicking on specification box.
Sample type assigned
image
Sample type not assigned
image

@markbes1
Copy link
Collaborator Author

@xispa can we get an update on this 🙏

@xispa
Copy link
Collaborator

xispa commented Oct 18, 2024

Sure, will try to address this tonight

@xispa
Copy link
Collaborator

xispa commented Oct 21, 2024

Addressed with #232 and deployed on Q-System and P-System

@xispa xispa added done Done, but not yet deployed in QA-System on pilot This one is available in Q-System and ready for testing on production This one is available on P-System labels Oct 21, 2024
@markbes1 markbes1 removed done Done, but not yet deployed in QA-System on production This one is available on P-System labels Oct 22, 2024
@markbes1
Copy link
Collaborator Author

Urine and Serum specifications still not being added for Tamanu lab requests and also not being assigned automatically when registering sample manually. They are being added for manually registered samples on pilot but not production

@xispa
Copy link
Collaborator

xispa commented Nov 4, 2024

Addressed with senaite/senaite.core#2639 and deployed on Q-System and P-System

@markbes1
Copy link
Collaborator Author

markbes1 commented Nov 4, 2024

Thank you it's working again for urine and serum

@markbes1 markbes1 closed this as completed Nov 4, 2024
@xispa xispa added done Done, but not yet deployed in QA-System on production This one is available on P-System labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is not working as expected done Done, but not yet deployed in QA-System on pilot This one is available in Q-System and ready for testing on production This one is available on P-System P0: critical We need this one before yesterday
Projects
None yet
Development

No branches or pull requests

2 participants