Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reassign specifications after adding analyses in manage analyses #53

Closed
markbes1 opened this issue Oct 19, 2023 · 5 comments
Closed

Reassign specifications after adding analyses in manage analyses #53

markbes1 opened this issue Oct 19, 2023 · 5 comments
Assignees
Labels
done Done, but not yet deployed in QA-System on pilot This one is available in Q-System and ready for testing on production This one is available on P-System P0: critical We need this one before yesterday

Comments

@markbes1
Copy link
Collaborator

markbes1 commented Oct 19, 2023

Steps to reproduce

Register sample then add tests through manage analyses that use same specification that was assigned during registration example: add urine microscopy to urinalysis tests

Current behavior

After adding analyses using manage analyses if the tests use the specification already assigned to that sample a warning appears at top of sample page "Ranges for some analyses are different from the Specification" and also next to analyses results saying "result range is different from specification"

Expected behavior

Give option in yellow warning bow (first screenshot) to reassign current analysis specification instead of having to go into sample fields and unassign and reassign the specification manually.

Screenshot (optional)

image

With current workflow for urine samples this problem occurs every time the lab has a positive urine sample

@markbes1 markbes1 added the P0: critical We need this one before yesterday label Oct 19, 2023
@markbes1
Copy link
Collaborator Author

Also need it when this warning box appears

image

@markbes1
Copy link
Collaborator Author

@xispa @Saharetesam for the yellow warning box above I think we should change the wording so it's a bit more clear to the users.

As far as I'm aware this warning appears only when users add analyses using manage analyses, maybe we could say
"New Analyses added please ensure tests use assigned specification and they can run on assigned sample type"

This could also be the warning the lab have asked for when people do add-on tests to make sure they are assigning the correct test based on sample type

@xispa xispa self-assigned this Oct 31, 2023
@xispa
Copy link
Collaborator

xispa commented Oct 31, 2023

This gets fixed with senaite/senaite.core#2415 that makes the re-assignment of the analysis specifications is no necessary anymore as long as the setting "Enable Sample Specifications" from site setup is disabled. Likewise, the alert panels are no longer displayed because the default specs are not overwritten when adding new analyses.

@xispa xispa added done Done, but not yet deployed in QA-System on pilot This one is available in Q-System and ready for testing on production This one is available on P-System labels Oct 31, 2023
@xispa
Copy link
Collaborator

xispa commented Oct 31, 2023

Deployed on Q-System and P-System

@markbes1
Copy link
Collaborator Author

Working on Pilot have informed Lab about change on production site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Done, but not yet deployed in QA-System on pilot This one is available in Q-System and ready for testing on production This one is available on P-System P0: critical We need this one before yesterday
Projects
None yet
Development

No branches or pull requests

2 participants