Skip to content

Commit 5f3575d

Browse files
committed
CI: Test stable (deno), dev (deno) and legacy (node)
1 parent 7de1e8c commit 5f3575d

File tree

1 file changed

+21
-32
lines changed

1 file changed

+21
-32
lines changed

.github/workflows/validate_datasets.yml

+21-32
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
fail-fast: false
2222
matrix:
2323
platform: [ubuntu-latest, macos-latest, windows-latest]
24-
bids-validator: [master, stable, master-deno]
24+
bids-validator: [stable, dev, legacy]
2525

2626
runs-on: ${{ matrix.platform }}
2727

@@ -33,53 +33,42 @@ jobs:
3333
- uses: actions/checkout@v4
3434

3535
- name: Set up Node.js
36-
if: "matrix.bids-validator == 'stable' || matrix.bids-validator == 'master'"
36+
if: matrix.bids-validator == 'legacy'
3737
uses: actions/setup-node@v4
3838
with:
3939
node-version: 18
4040

41-
- name: Install BIDS validator (stable)
42-
if: "matrix.bids-validator == 'stable'"
43-
run: |
44-
npm install -g bids-validator
45-
46-
- name: Install BIDS validator (master)
47-
if: "matrix.bids-validator == 'master'"
48-
run: |
49-
pushd ..
50-
# Get npm 7+
51-
npm install -g npm
52-
git clone --depth 1 https://github.com/bids-standard/bids-validator
53-
cd bids-validator
54-
# Generate the full development node_modules
55-
npm clean-install
56-
# Build & bundle the bids-validator CLI package
57-
npm -w bids-validator run build
58-
# Generate a package to install globally
59-
npm -w bids-validator pack
60-
# Install the package globally
61-
bash -c "npm install -g bids-validator-*.tgz"
62-
popd
63-
6441
- uses: denoland/setup-deno@v2
65-
if: "matrix.bids-validator == 'master-deno'"
42+
if: matrix.bids-validator != 'legacy'
6643
with:
67-
deno-version: v1.x
44+
deno-version: v2.x
6845

69-
- name: Install BIDS validator (master deno build)
70-
if: "matrix.bids-validator == 'master-deno'"
46+
- name: Install BIDS validator (stable)
47+
if: matrix.bids-validator == 'stable'
48+
run: |
49+
deno install -Agf -n bids-validator jsr:@bids/validator
50+
shell: bash
51+
52+
- name: Install BIDS validator (dev)
53+
if: matrix.bids-validator == 'dev'
7154
run: |
7255
# If unmerged validator PRs are needed for testing, you can use
7356
# https://github.com/<FORK>/bids-validator/raw/<BRANCH>/bids-validator/src/bids-validator.ts
7457
deno install -Agf https://github.com/bids-standard/bids-validator/raw/deno-build/bids-validator.js
7558
shell: bash
7659

60+
- name: Install BIDS validator (legacy)
61+
if: "matrix.bids-validator == 'legacy'"
62+
run: |
63+
npm install -g bids-validator
64+
7765
- name: Display versions and environment information
7866
run: |
7967
echo $TZ
8068
date
81-
echo "npm"; npm --version
82-
echo "node"; node --version
69+
which deno && echo "deno\n----" && deno --version || true
70+
echo "node\n----"; node --version
71+
echo "npm\n----"; npm --version
8372
echo "bids-validator"; bids-validator --version
8473
shell: bash
8574

@@ -100,7 +89,7 @@ jobs:
10089

10190
- name: Skip MRS validation for legacy validator
10291
run: for DS in mrs_* dwi_deriv; do touch $DS/.SKIP_VALIDATION; done
103-
if: "matrix.bids-validator != 'master-deno'"
92+
if: matrix.bids-validator == 'legacy'
10493
shell: bash
10594

10695
- name: Validate all BIDS datasets using bids-validator

0 commit comments

Comments
 (0)