Enable checks for multiple imports on same line (E401) and "import *" (F403, F405) (senaite#2092)

* Remove unused import

* Enable check for multiple imports on one line (E401)

* Enable check for "import *" (F403)

* Enable check for "import *" (F405)

* Remove unnecessary commas from flake8 config

Author: winniehell

src/bika/lims/browser/client/views/analysisprofiles.py

@@ -20,7 +20,7 @@
 
 from bika.lims import bikaMessageFactory as _
 from bika.lims.browser.bika_listing import BikaListingView
-from bika.lims.permissions import *
+from bika.lims.permissions import AddAnalysisProfile
 from Products.CMFCore.utils import getToolByName
 
 

src/bika/lims/browser/client/views/artemplates.py

@@ -20,7 +20,7 @@
 
 from bika.lims import bikaMessageFactory as _
 from bika.lims.browser.bika_listing import BikaListingView
-from bika.lims.permissions import *
+from bika.lims.permissions import AddARTemplate
 from Products.CMFCore.utils import getToolByName
 
 

src/bika/lims/jsonapi/__init__.py

@@ -29,13 +29,13 @@
 import json
 import Missing
 import six
-import sys, traceback
+import sys
+import traceback
 
 
 def handle_errors(f):
     """ simple JSON error handler
     """
-    import traceback
     from plone.jsonapi.core.helpers import error
 
     def decorator(*args, **kwargs):

travis_ci_flake8.cfg

@@ -65,18 +65,12 @@ extend-ignore =
     E305,
     # E306: expected 1 blank line before a nested definition, found 0
     E306,
-    # E401: multiple imports on one line
-    E401,
     # E501: line too long (80 > 79 characters)
     E501,
     # E502: the backslash is redundant between brackets
     E502,
     # E722: do not use bare 'except'
     E722,
-    # F403: 'from bika.lims.permissions import *' used; unable to detect undefined names
-    F403,
-    # F405: 'AddAnalysisProfile' may be undefined, or defined from star imports: bika.lims.permissions
-    F405,
     # F632: use ==/!= to compare constant literals (str, bytes, int, float, tuple)
     F632,
     # F706: 'return' outside function
@@ -102,14 +96,17 @@ extend-ignore =
     # W605: invalid escape sequence '\d'
     W605,
 per-file-ignores =
-    src/bika/lims/skins/bika/guard_handler.py:F401,
-    src/bika/lims/browser/worksheet/views/__init__.py:F401,
-    src/bika/lims/browser/analyses/__init__.py:F401,
-    src/bika/lims/browser/client/__init__.py:F401,
-    src/bika/lims/browser/widgets/__init__.py:F401,
-    src/bika/lims/browser/analysisrequest/analysisrequests.py:F401,
-    src/bika/lims/browser/analysisrequest/__init__.py:F401,
-    src/bika/lims/subscribers/__init__.py:F401,
-    src/bika/lims/interfaces/__init__.py:F401,
-    src/senaite/core/exportimport/instruments/__init__.py:F401,
-    src/senaite/core/behaviors/__init__.py:F401,
+    # ignore unused imports (F401) in meta packages
+    src/bika/lims/skins/bika/guard_handler.py:F401
+    src/bika/lims/browser/worksheet/views/__init__.py:F401
+    src/bika/lims/browser/analyses/__init__.py:F401
+    src/bika/lims/browser/client/__init__.py:F401
+    src/bika/lims/browser/widgets/__init__.py:F401
+    src/bika/lims/browser/analysisrequest/analysisrequests.py:F401
+    src/bika/lims/browser/analysisrequest/__init__.py:F401
+    src/bika/lims/subscribers/__init__.py:F401
+    src/bika/lims/interfaces/__init__.py:F401
+    src/senaite/core/exportimport/instruments/__init__.py:F401
+    src/senaite/core/behaviors/__init__.py:F401
+    # ignore "import *" (F403, F405) in Archetypes models
+    src/bika/lims/content/*.py:F403,F405