Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish support #22

Closed
lennihein opened this issue Nov 27, 2022 · 5 comments
Closed

Fish support #22

lennihein opened this issue Nov 27, 2022 · 5 comments
Assignees
Labels
feature Discusses the implementation of a new feature.

Comments

@lennihein
Copy link

lennihein commented Nov 27, 2022

emit is already a command in fish.

alias emit (which emit)

seems to be a suitable workaround

@lennihein lennihein added the feature Discusses the implementation of a new feature. label Nov 27, 2022
@larsborn
Copy link
Contributor

Would using a "prefix" be a solution for you (see the ).

@lennihein
Copy link
Author

@larsborn

Would using a "prefix" be a solution for you (see the ).

I suppose that would be a solution. On my system it kept installing binref without the prefix since the packages were still cached! Removing the .cache/pip/ folder fixed it.

I'll keep updating this thread while I continue using binref with Fish.

@huettenhain
Copy link
Member

If you can think of a more satisfying solution than having to use a prefix, we should definitely re-open this and try to implement it. I will also install fish and try out a few things to get a better feel for the shell.

@jhhcs
Copy link
Contributor

jhhcs commented Nov 28, 2022

The current behavior in both a virtual environment and everywhere else is that fish's internal emit command wins out over any executables that exist on the path, which is what I expected, unless you explicitly use an alias like @lennihein suggested.

One option that obviously comes to mind is to rename the emit unit to something else. The main effort on my part is that I would have to change a lot of existing documentation, and the main problem is that there is documentation that I cannot edit, like the OALabs video and Johannes Bader's blog post.

My current suggestion would be to do the following:

alias event-emit="builtin emit"
alias emit=(which emit)

This preserves the ability to use fish's builtin emit by running event-emit while emit will be the corresponding refinery unit.

@jhhcs
Copy link
Contributor

jhhcs commented Nov 28, 2022

PS: Lots of interesting stuff on how to work with aliases in this stackexchange post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Discusses the implementation of a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants