Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

galaxy pasteur tool name #282

Closed
hansioan opened this issue Nov 13, 2017 · 8 comments
Closed

galaxy pasteur tool name #282

hansioan opened this issue Nov 13, 2017 · 8 comments
Assignees
Labels
content Concerns bio.tools content. data model / integrity / quality Concerns the underlying data model (verification, validity etc.) high priority We get to these once "critical priority" issues are done.

Comments

@hansioan
Copy link
Member

Names of galaxy pasteur tools end in -IP, I think we should changed that to be (IP)
example: trimmomatic-IP becomes trimmomatic (IP)

@joncison you agree?

@joncison joncison added the content Concerns bio.tools content. label Nov 15, 2017
@joncison
Copy link
Member

According to naming patterns (http://biotools.readthedocs.io/en/latest/curators_guide.html#id18) that's right but if I recall right, I didn't bother renaming (in the spreadsheet from hell) tools whose descriptions are generated automatically, such as for Galaxy Pasteur. Probably better to update regate (the tooling used for this), cc @hmenager to advise!

@hansioan
Copy link
Member Author

@joncison to take this as a final stage of refactoring for "canonical" entries.

@hansioan hansioan added the data model / integrity / quality Concerns the underlying data model (verification, validity etc.) label Sep 11, 2018
@joncison joncison added the in progress We're actively working on this. label Dec 4, 2018
@joncison
Copy link
Member

joncison commented Dec 4, 2018

As discussed with @hmenager and @hansioan, I will go through these "*-IP" entries systematically, identifying ...

... entries where an independent tool exists, should be refactored into "canonical" entries (i.e. ):

  1. retain existing homepage as <link><url>...</url><type>Service</type></link>
  2. change homepage to tool homepage (not Galaxy)
  3. change both name and ID, e.g. "breseq-IP" -> "breseq"

entries for which an independent tool does not exist

  1. change name e.g. "breseq-IP" -> "breseq (IP)"

(this will need a revision to biotoolsSchema, see bio-tools/biotoolsSchema#129)

@joncison
Copy link
Member

joncison commented Dec 6, 2018

@hmenager - I took a look at this, but multiple things cropped up:

  • there are some tools in the IP Galaxy that we don't have
  • some tools we do have, but which are obsolete
  • some of IP Galaxy services wrap tools belonging to suites, e.g. of SAM tools. It would be good to have these - but ideally we'd need a way to formally relate such entries in bio.tools (see Modelling tool relations and versions (placeholder discussion) biotoolsSchema#106)
  • I suspect some services wrap individual functions / modes of operations of tools - need to investigate this more / decide what to do
  • in cases where we want to convert an entry to describe the "canonical" tool, we want to preserve the link to IP Galaxy, which needs a new schema element (see Add "Service" to <link><type> enum biotoolsSchema#129)

Doing this is too much for this year, so I propose we get together with @hansioan next year, and dedicate a few days to this, and get it right. Is that OK?

@joncison joncison added high priority We get to these once "critical priority" issues are done. and removed in progress We're actively working on this. labels Dec 6, 2018
@joncison joncison added this to the 2019 Q1 release milestone Dec 10, 2018
@joncison
Copy link
Member

joncison commented Feb 5, 2019

@hmenager @hansioan can we take a quick skype this morning to discuss briefly ... Hans and I need to understand, of the tools imported from Galaxy pasteur (where the descriptions are awesome, by the way!), what tools exist only in that instance (and so can keep their name/IDs) and what tools exist independently (where we'd need to merge into / create the "canonical" entries with appropriate names and IDs)

@joncison
Copy link
Member

joncison commented Feb 5, 2019

update from call with @hmenager & @hansioan we now have:
https://docs.google.com/spreadsheets/d/13sJxbfzG1rbfoqiKo_ilB4ZEKd0EmhDUoz55iYFDpHM/edit#gid=0

Actions:

  • Herve to complete spreadsheet and hand over to Hans & I
  • rename tools & IDs dropping the "-IP" suffix
  • preserve existing homepage as link
  • hotfix link->type enum extension for "Galaxy service" (see Add "Service" to <link><type> enum biotoolsSchema#129) (using this for links)
  • assign tools in suites (or "functional units" in packages) to a collection annotation (to be later refactored using formalised relationships)
  • ensure we have corresponding entries for all the suites / packages bundled in Galaxy IP, e.g. that we have a bedtools entry (also annotating this to the corresponding collection)

@joncison joncison added the done - staged for release Issue is implemented in dev.bio.tools. label Feb 22, 2019
@joncison
Copy link
Member

all now done @hmenager

@joncison joncison removed the done - staged for release Issue is implemented in dev.bio.tools. label Apr 10, 2019
@joncison
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Concerns bio.tools content. data model / integrity / quality Concerns the underlying data model (verification, validity etc.) high priority We get to these once "critical priority" issues are done.
Projects
None yet
Development

No branches or pull requests

3 participants