Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tradeHistory.csv inconsistencies regarding Canceled Trades (& Failed Trades) #7360

Open
heronimoo opened this issue Jan 22, 2025 · 0 comments

Comments

@heronimoo
Copy link

heronimoo commented Jan 22, 2025

Description

Canceled (and Failed) Trades are shown in tradeHistory.csv, but there are inconsistencies:

  1. The "Transaction Fee" is shown as 0.00, but since the transaction has been published, a transaction fee also has occurred, which can be verified in transactions.csv and on a block explorer. So tradeHistory.csv should show that fee. At the moment, the only way to get that fee is to check that transaction on a block explorer, since transactions.csv contains incorrect values for maker fee transactions. The Trade Fee (in BSQ) is shown correctly.
  2. Some Canceled Trades, however, really do not have a transaction fee - if they were cancelled before the transaction has been confirmed (I think). Under trade details, a maker fee transaction is shown and appears green - which is confusing, since it cannot be found on a block explorer, and therefore should not have caused any fees (right?). In this case, tradeHistory.csv shows the correct Transaction Fee ("0"), but an incorrect Trade Fee (it's showing a BSQ value instead of "0").
  3. I found similar inconsistencies with Failed Trades - but haven't looked into the details, since I've only had a very few of these cases.

Version

1.9.18, but has been like this for as long as I have been using the CSV files (at least since 2023/2024).

Steps to reproduce

  1. Create an Offer
  2. Cancel it before the maker fee transaction has been published.
  3. Create another Offer
  4. Cancel it after the maker fee transaction has been published.
  5. Compare both Canceled Trades in tradeHistory.csv, transactions.csv, and on mempool.space
  6. Find the described inconsistent behaviour.

Expected behaviour

Consistent behaviour with correct values.

Actual behaviour

Incorrect values and inconsistent handling of Cancelled & Failed Trades, depending on whether maker fee transactions have been confirmed or not.

Device or machine

Tested on Windows and Linux across many Bisq versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant