You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In comment of both DECIMAL_FORMAT_SYMBOLS and US_LOCALE_NUMBER_FORMAT it is mentioned that commas should be omitted from number strings, but US_LOCALE_NUMBER_FORMAT produces strings that include comma
is this intended ? if so the comment needs to be updated
if not, then the formatting is producing incorrect results
bisq/cli/src/main/java/bisq/cli/CurrencyFormat.java
Lines 42 to 46 in 0fea955
In comment of both
DECIMAL_FORMAT_SYMBOLS
andUS_LOCALE_NUMBER_FORMAT
it is mentioned thatcommas should be omitted from number strings
, butUS_LOCALE_NUMBER_FORMAT
produces strings that include commais this intended ? if so the comment needs to be updated
if not, then the formatting is producing incorrect results
also rounding mode in formatPrice is a bit vague:
bisq/cli/src/main/java/bisq/cli/CurrencyFormat.java
Line 106 in 0fea955
was the intention to simply truncate the price and not round it ? because java docs show that
UNNECESSARY
rounding throws ArithmeticException in many cases:https://docs.oracle.com/javase/8/docs/api/java/math/RoundingMode.html
The text was updated successfully, but these errors were encountered: