Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug at mediation payout #7401

Open
HenrikJannsen opened this issue Feb 22, 2025 · 5 comments · May be fixed by #7408
Open

Bug at mediation payout #7401

HenrikJannsen opened this issue Feb 22, 2025 · 5 comments · May be fixed by #7408
Assignees

Comments

@HenrikJannsen
Copy link
Collaborator

The change of the min. deposit amount was not applied to the payout suggestion in the mediator payout screen.

Reported by mediator:
I have a mediation case in Bisq where the payout proposal ended up being calculated wrong in the application
Trade amount was 0.0004 BTC
Deposits were 0.0003 BTC
Trade was proposed to be cancelled
The application calculated the incorrect amounts

Image

@HenrikJannsen HenrikJannsen self-assigned this Feb 22, 2025
@pazza83
Copy link

pazza83 commented Feb 22, 2025

To incentivize the losing party at mediation to accept mediation rather than abandon the trade or take the trade to mediation they are currently always left with whatever is the greater amount from the following:

5% of the trade amount, OR
0.0005 BTC

Due to Bisq reducing the deposit amount to 0.0003 BTC in v1.9.19 this creates the situation where the mediation proposal made can leave a losing party with a payout proposal of 0.0005 BTC (which is more than their deposit).

As a result the mediation proposal mechanism should be changed so that a trader is always left with whatever is the greater amount from the following:

5% of the trade amount, OR
0.00015 BTC

@pazza83
Copy link

pazza83 commented Feb 22, 2025

Thinking more about it the min amount should be reduced to 0.0001 BTC, so at least a scammer stands to lose two thirds of their deposit.

@HenrikJannsen
Copy link
Collaborator Author

Thinking more about it the min amount should be reduced to 0.0001 BTC, so at least a scammer stands to lose two thirds of their deposit.

Shouldn't that be covered by using the penalty option? The "seller/buyer gets trade amount" option is for a settlement without loss to anyone. No?

@HenrikJannsen HenrikJannsen linked a pull request Mar 5, 2025 that will close this issue
@HenrikJannsen
Copy link
Collaborator Author

#7408 use the same logic as it is now (50% deposit as the min. amount to payout to leave some incentives to accept the result).

@pazza83
Copy link

pazza83 commented Mar 6, 2025

Yes, happy for it to be left as:

5% of the trade amount, OR
0.00015 BTC

I think my suggestion for a lower amount was geared towards a few chargeback scammers we had recently were it would be nice to recommend less than this. But with reflection the previous logic has worked well so if it is not broke no need to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants