Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal_delete_operation issues #146

Open
vikramrajkumar opened this issue Jan 18, 2017 · 0 comments
Open

proposal_delete_operation issues #146

vikramrajkumar opened this issue Jan 18, 2017 · 0 comments

Comments

@vikramrajkumar
Copy link
Contributor

From @abitmore on January 9, 2016 4:3

  1. proposal_delete_operation doesn't recursively check the authorities in case when multi-sig authority involved. See https://bitsharestalk.org/index.php/topic,20861.msg271080.html#msg271080, it's a try to delete an incorrect committee proposal, but failed due to this reason:
    10 assert_exception: Assert Exception required_approvals->find(o.fee_paying_account) != required_approvals->end(): Provided authority is not authoritative for this proposal. {"provided":"1.2.12376","required":["1.2.0"]}
  2. This operation allows the early veto of a proposed transaction. It may be used by any account which is a required authority on the proposed transaction, when that account's holder feels the proposal is ill-advised and he decides he will never approve of it and wishes to put an end to all discussion of the issue.
    Imo it's better to set a threshold equals to (total_weight - approve_threshold) for proposal_delete_operation, so the proposal will only be deleted if enough authorities agree to delete the proposal.

Copied from original issue: cryptonomex/graphene#515

@oxarbitrage oxarbitrage added this to the Hardfork - Operations changes milestone Aug 13, 2017
@abitmore abitmore added the bug label Feb 20, 2018
@abitmore abitmore modified the milestones: Hardfork - Operations and Authority related., Future Consensus-Changing Release Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants