Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE & BE: Incidents for other monitor types #1844

Open
ajhollid opened this issue Feb 28, 2025 · 10 comments
Open

FE & BE: Incidents for other monitor types #1844

ajhollid opened this issue Feb 28, 2025 · 10 comments

Comments

@ajhollid
Copy link
Collaborator

Current behavior: The "Incidents" table only displays incidents for regular Uptime monitors. If a monitor of another type is selected no incidents are shown.

Expected behavior: The "Incidents" table should show incidents for all types of monitors. If a monitor of another type is selected incidents for that monitor should be shown.

@jasneetsingh6114
Copy link
Contributor

Hello, I’d like to work on this issue. Could you please assign it to me?

@ajhollid
Copy link
Collaborator Author

ajhollid commented Mar 1, 2025

Hi @jasneetsingh6114,

This issue requires a well thought out approach, if you'd like to work on it please post a brief proposal and we'll see if it fits the project goals.

Thanks!

@Owaiseimdad
Copy link
Contributor

@ajhollid , could you please share a screenshot of the current behavior? I'm having trouble understanding the issue.

@ajhollid
Copy link
Collaborator Author

ajhollid commented Mar 1, 2025

@Owaiseimdad there are four types of monitors, uptime, hardware, PageSpeed, and distributed.

The page currently only shows incidents for Uptime type monitors.

You can test this by creating different monitor and types.

@Owaiseimdad
Copy link
Contributor

Thanks for the brief here @ajhollid.
I get that there are four types of monitoring here, uptime, infrastructure, page-speed and distributed (you need to enable it)

Now, its shows only monitor and and from looking at the code and UI it looks like they had only uptime in mind and we definitely need to add more.

@jasneetsingh6114
Copy link
Contributor

jasneetsingh6114 commented Mar 1, 2025

I'd love to work on this issue! My approach includes updating the incidents page (src/Pages/Incidents/index.jsx) to ensure it displays incidents for all four monitor types (Uptime, Hardware, PageSpeed, and Distributed). I'll review API calls in NetworkService.js to fetch incidents for all monitor types, check filtering logic in monitorUtils.js, update the table component if needed, and verify state management in store.js. I’ll also test by creating different monitor types to ensure full coverage. Let me know if this approach aligns with the project goals!

@Br0wnHammer
Copy link
Contributor

Hi @gorkem-bwl,
Could you please assign this issue to me? I've discussed an approach with Alex, and it seems to be on the right track.

@ajhollid ajhollid changed the title FE & BE: Incidents for othe rmonitor types FE & BE: Incidents for other monitor types Mar 3, 2025
@Owaiseimdad
Copy link
Contributor

@Br0wnHammer I do see an api which is getting called and has all the data we might need.
The path contains /api/v1/monitors/team and response data has all the type.
Let me know if this helps.

@Br0wnHammer
Copy link
Contributor

@Owaiseimdad Thanks for the info! I'll test out the /api/v1/monitors/team endpoint as well to see how it fits into our requirements. Let's see how it goes!

@Br0wnHammer
Copy link
Contributor

Hey @gorkem-bwl, we can close out this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants