-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE & BE: Incidents for other monitor types #1844
Comments
Hello, I’d like to work on this issue. Could you please assign it to me? |
This issue requires a well thought out approach, if you'd like to work on it please post a brief proposal and we'll see if it fits the project goals. Thanks! |
@ajhollid , could you please share a screenshot of the current behavior? I'm having trouble understanding the issue. |
@Owaiseimdad there are four types of monitors, uptime, hardware, PageSpeed, and distributed. The page currently only shows incidents for Uptime type monitors. You can test this by creating different monitor and types. |
Thanks for the brief here @ajhollid. Now, its shows only monitor and and from looking at the code and UI it looks like they had only uptime in mind and we definitely need to add more. |
I'd love to work on this issue! My approach includes updating the incidents page (src/Pages/Incidents/index.jsx) to ensure it displays incidents for all four monitor types (Uptime, Hardware, PageSpeed, and Distributed). I'll review API calls in NetworkService.js to fetch incidents for all monitor types, check filtering logic in monitorUtils.js, update the table component if needed, and verify state management in store.js. I’ll also test by creating different monitor types to ensure full coverage. Let me know if this approach aligns with the project goals! |
Hi @gorkem-bwl, |
@Br0wnHammer I do see an api which is getting called and has all the data we might need. |
@Owaiseimdad Thanks for the info! I'll test out the |
Hey @gorkem-bwl, we can close out this issue. |
Current behavior: The "Incidents" table only displays incidents for regular Uptime monitors. If a monitor of another type is selected no incidents are shown.
Expected behavior: The "Incidents" table should show incidents for all types of monitors. If a monitor of another type is selected incidents for that monitor should be shown.
The text was updated successfully, but these errors were encountered: