fix sorting difflayer.storage

Author: dean65

core/blockchain.go

@@ -521,14 +521,9 @@ func (bc *BlockChain) cacheDiffLayer(diffLayer *types.DiffLayer, diffLayerCh cha
 	sort.SliceStable(diffLayer.Storages, func(i, j int) bool {
 		return diffLayer.Storages[i].Account.Hex() < diffLayer.Storages[j].Account.Hex()
 	})
-	for _, storage := range diffLayer.Storages {
+	for index := range diffLayer.Storages {
 		// Sort keys and vals by key.
-		sort.SliceStable(storage.Keys, func(i, j int) bool {
-			return storage.Keys[i] < storage.Keys[j]
-		})
-		sort.SliceStable(storage.Vals, func(i, j int) bool {
-			return storage.Keys[i] < storage.Keys[j]
-		})
+		sort.Sort(&diffLayer.Storages[index])
 	}
 
 	if bc.diffLayerCache.Len() >= diffLayerCacheLimit {

core/types/block.go

@@ -480,6 +480,13 @@ type DiffStorage struct {
 	Vals    [][]byte
 }
 
+func (storage *DiffStorage) Len() int { return len(storage.Keys) }
+func (storage *DiffStorage) Swap(i, j int) {
+	storage.Keys[i], storage.Keys[j] = storage.Keys[j], storage.Keys[i]
+	storage.Vals[i], storage.Vals[j] = storage.Vals[j], storage.Vals[i]
+}
+func (storage *DiffStorage) Less(i, j int) bool { return storage.Keys[i] < storage.Keys[j] }
+
 type DiffAccountsInTx struct {
 	TxHash   common.Hash
 	Accounts map[common.Address]*big.Int