DefineConstants csproj attribute is ignored by Extension's compiler

[bruno-f-cruz]

When trying to use protobuf c# code generator (https://protobuf.dev/reference/csharp/csharp-generated/) with older versions of .NET, one must toggle the GOOGLE_PROTOBUF_REFSTRUCT_COMPATIBILITY_MODE compiler flag (https://github.com/protocolbuffers/protobuf/tree/main/csharp). However, this flag seems to be ignored by the Extensions compiler. This is what I am trying:

  <PropertyGroup>
    <DefineConstants>GOOGLE_PROTOBUF_REFSTRUCT_COMPATIBILITY_MODE</DefineConstants>
  </PropertyGroup>

[PathogenDavid]

Correct, Bonsai uses a very naive interpretation of Extensions.csproj which only supports:

• ProjectReference items (Include and Version properties only)
• UseWindowsForms (for visualizers)
• AllowUnsafeBlocks (for Gonçalo and me)

(@banchan86 maybe this is something we should mention in the scripting extensions documentation?)

We could potentially add similar naive parsing of DefineConstants, but it's actually harder to fully support since it's more flexible than the others since it has SDK defaults. (On that note, <DefineConstants>$(DefineConstants);GOOGLE_PROTOBUF_REFSTRUCT_COMPATIBILITY_MODE</DefineConstants> is more correct.)

We've talked a few times about either reworking how Bonsai environments work entirely or reworking how scripting extensions work to make this less rigid, but it's not a simple problem to solve.

(As an aside this issue gave me a new idea for some proposals I'm working on that are semi-related so thanks for posting it!)