Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider auto-filling nuspec elements in exported gallery packages #2133

Open
glopesdev opened this issue Feb 10, 2025 · 1 comment
Open
Labels
proposal Request for a new feature
Milestone

Comments

@glopesdev
Copy link
Member

  • README.md if there is one
  • LICENSE if there is one
  • Avoid using licenseUrl and iconUrl as they are not recommended anymore
@glopesdev glopesdev added the proposal Request for a new feature label Feb 10, 2025
@glopesdev glopesdev added this to the 2.9 milestone Feb 10, 2025
@glopesdev glopesdev changed the title Consider auto-filling certain nuspec elements in exported gallery packages Consider auto-filling nuspec elements in exported gallery packages Feb 10, 2025
@PathogenDavid
Copy link
Member

For a bit of extra context/thoughts from DCM:

  • Initially the context for this was being able to store metadata in a central place like many .NET projects do with Directory.Build.props
  • We could also just have Bonsai remember the last settings used in the .bonsai folder (not ideal because we want people to use the Gallery or some evolution of it more readily.)
  • Could live in a more authoritative evolution of Extensions.csproj (this would have to be a long-term solution, assuming we ever even do this)

An extra thought I had on the first one: If we want the metadata to be stored in a Workflow.bonsai or this central location (IE: Company name in Directory.Bonsai.nuspec, package name in Workflow.bonsai), how do we determine which one wins? For example some projects might want a single icon for all examples but others might do custom ones.

In a MSBuild context the project generally "wins" since Directory.Build.props is logically imported at the top of the project. However in a modern MSBuild context people are editing their projects by hand, so "use Directory.Build.props" is signified purely by the property missing. With Bonsai I think the expectation should more be that the GUI is able to be the only interface and it's slightly harder to have a clean interface that lets you have both. (Even if we say Directory.Bonsai.nuspec is an advanced user feature that has to be maintained with a text editor.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants