Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify=False not work with python bug PHA #2702

Closed
yywing opened this issue Jun 21, 2022 · 4 comments
Closed

verify=False not work with python bug PHA #2702

yywing opened this issue Jun 21, 2022 · 4 comments
Assignees
Labels
certs p3 This is a minor priority issue

Comments

@yywing
Copy link

yywing commented Jun 21, 2022

Describe the bug

python has ssl bug: https://bugs.python.org/issue37428

This commit try fix it: e97f5cb

but create_urllib3_context has default args and context.post_handshake_auth is always True.

image

image

Expected Behavior

verfity=False not validate cert.

Current Behavior

When ? (3.6 or smaller )< python version < 3.7.4 and openssl > 1.1.1, then always verfity ssl cert.

Reproduction Steps

--

Possible Solution

#2703

Additional Information/Context

No response

SDK version used

= this commit (e97f5cb)

Environment details (OS name and version, etc.)

  • (3.6 or smaller )< python version < 3.7.4 (suuport PHA)
  • openssl > 1.1.1 (support PHA)
  • server support tls1.3
@yywing yywing added bug This issue is a confirmed bug. needs-triage This issue or PR still needs to be triaged. labels Jun 21, 2022
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 21, 2022
@RyanFitzSimmonsAK RyanFitzSimmonsAK added the p3 This is a minor priority issue label Nov 3, 2022
@tim-finnigan
Copy link
Contributor

Hi @yywing thanks for your patience. I wanted to confirm that this is still an issue you are seeing. Support for Python 3.6 has since been deprecated as of May 2022 per this announcement. If this is still an issue in Python 3.7+ please let us know.

@tim-finnigan tim-finnigan added response-requested Waiting on additional info and feedback. certs and removed bug This issue is a confirmed bug. investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Nov 23, 2022
@yywing
Copy link
Author

yywing commented Nov 24, 2022

(3.6 or smaller )< python version < 3.7.4 and openssl > 1.1.1

So python 3.7.1 will be affect

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. label Nov 24, 2022
@tim-finnigan tim-finnigan self-assigned this Sep 25, 2023
@tim-finnigan
Copy link
Contributor

Thanks again for your patience and for creating that PR. In the announcement linked earlier, the planned end of support for Python 3.7 is December 2023. And in the meantime Python 3.7.4+ can be used. For these reasons the team has not prioritized this issue or PR.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
certs p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

3 participants