Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPG utility #329

Open
feamsr00 opened this issue Nov 20, 2018 · 5 comments
Open

Add GPG utility #329

feamsr00 opened this issue Nov 20, 2018 · 5 comments

Comments

@feamsr00
Copy link

Feature Request

(I suppose this is a feature request if it was consciously removed during the forking)

The original project (https://github.com/box-project/box2/blob/2.7.5/src/lib/KevinGH/Box/Command/Key/Create.php) had the ability to simply create a key from the cli. I sense there's a general push to a more "comprehensive" solution (Phive) but I think it still makes sense to add the command. Any particular reason it was removed?

Thanks!

@theofidry
Copy link
Member

It has been removed because I had limited time to spare on the project and preferred to focus on the core and did not see the value in it.

Besides pushing more towards phive, I would also prefer to push towards GPG signing and signing the PHAR as an artefact rather than relying on the PHAR built-in signing feature which is useless IMO.

So with this mind, I don't think the key:create command really have any place anymore. One thing I could see is however is supporting the GPG signing during the build process. I mean it's literally one line when you have the key:

gpg -u [email protected] --detach-sign --output your.phar.asc your.phar

but I think it would be a better DX still.

@theofidry
Copy link
Member

Do you have any argument in favour of key:create still or you're on with the new approach and we can close this issue?

@feamsr00
Copy link
Author

I'd say your rationale is reasonable but as you stated the DX could be better. And its right there I would say, if it can be better, it should be better!*

As such perhaps a util: or helper: gpg-sign command. Other than depending on a gpg binary, it would be as simple as you say, and would be a nice, little, well rounded feature. Thoughts?

*YMMV!

@theofidry
Copy link
Member

I'm all up for it, I just had too little time to take a look at it :) However a PR would be more than welcomed 😄

@theofidry theofidry changed the title Key Creation Add GPG utility Dec 10, 2018
@theofidry
Copy link
Member

This would probably have to use https://github.com/singpolyma/openpgp-php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants