Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor mistakes in 1st edition #6

Open
kuba-04 opened this issue Sep 17, 2024 · 3 comments
Open

minor mistakes in 1st edition #6

kuba-04 opened this issue Sep 17, 2024 · 3 comments

Comments

@kuba-04
Copy link

kuba-04 commented Sep 17, 2024

not a big deal, I believe this is just a fresh 1st edition so some mistakes are understandable.

A "bug" in the book:
page 213 we are adding a block of code:
block.verify_transactions( self.block_height(), &self.utxos, )?;

then on the page 217 the book says:
"you should have not just no errors, but also no warnings"

but it can't compile because the above method will be added just when we are reading further!

I think I have spotted similar but smaller things before but didn't note them down. Do you want me to add such notes here under this thread, so it will be easier to correct things for the second edition?

Great book btw! I really enjoy following it. Thank you @luciusmagn for this effort

@kuba-04
Copy link
Author

kuba-04 commented Sep 19, 2024

again: page 226
self.mempool
we never added mempool, the previous page shows clearly Blockchain fields as of now:
utxos, target, blocks
so mempool wasn't added and we have to comment out to compile.

@masud-abdulkadir
Copy link

Hey, i bumped into the same thing, but i thought the author was making a cheeky joke because of the ":)" smiley face. Otherwise I can confirm the same.

@arejula27
Copy link

Yep, I spent time looking for the function implementation in the previous pages, definitely not convenient, haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants