Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons from the payment method dropdown menu are not being used #44448

Open
3 of 6 tasks
kjozwiak opened this issue Mar 5, 2025 · 0 comments
Open
3 of 6 tasks

icons from the payment method dropdown menu are not being used #44448

kjozwiak opened this issue Mar 5, 2025 · 0 comments
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes misc/icons OS/Android Fixes related to Android browser functionality OS/Desktop QA/Yes release-notes/exclude

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Mar 5, 2025

Description

Looks like the only icons that are being used/being added into the list of the various crypto companies is Credit & Debit. If you pick any other choice from the list, you'll notice a placeholder where the Credit & Debit icons were, but there's nothing there other than a small grey box. See screenshots below for examples.

Steps to reproduce

  1. launch 1.78.18 Chromium: 134.0.6998.39 (any version of Brave that has Meld should reproduce)
  2. go into brave://wallet and click on Buy (go through Meld.io opt-in if it's a new wallet being created)
  3. notice that there's a credit card/bank icon appearing when Credit & Debit Cards is selected
  4. select other payment methods via the dropdown and notice there's no icons but a grey empty box

Actual result

Example Example Example
Image Image Image

Expected result

Believe it should place the icons within the empty grey box so it's easier to visualize which which purchasing method you're looking for within the list.

Reproduces how often

Easily reproduced

Desktop Brave version (brave://version info)

Brave | 1.78.18 Chromium: 134.0.6998.39 (Official Build) nightly (64-bit)
-- | --
Revision | fe0835c349223ad00d66d90ddee138365d21d165
OS | Windows 11 Version 24H2 (Build 26100.3194)

Android device

  • Brand/model: Pixel 8 Pro & Pixel 6 Pro
  • Android version: Android 15

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@kjozwiak kjozwiak added OS/Android Fixes related to Android browser functionality OS/Desktop misc/icons QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support labels Mar 5, 2025
@Douglashdaniel Douglashdaniel self-assigned this Mar 5, 2025
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes misc/icons OS/Android Fixes related to Android browser functionality OS/Desktop QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

2 participants