Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows tests are failing #12

Open
yasonk opened this issue Feb 10, 2025 · 0 comments
Open

Windows tests are failing #12

yasonk opened this issue Feb 10, 2025 · 0 comments

Comments

@yasonk
Copy link
Contributor

yasonk commented Feb 10, 2025

Windows is a low priority for now. But when we need to fix the windows tests, we should probably make "LocalCommandExecutor" just run commands in the container just like ContainerCommandExecutor, but map the "data" directory as a volume for the container. This is probably the better way to go in general because it limits the impact of commands run and will prevent "LocalComandExecutor" from ruining the users machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant