-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sub folder reconciliation logic #1068
Comments
I like it, we would graciously accept a pr! |
@samj1912 How would you expect kpack to detect sub directory specific changes? |
I would imagine that the source controller would need to be changed so that it has the latest commit and the latest effective commit and a build to be triggered only if the latest effective commit changes. The latest commit reconciliation logic would remain as is but we would need to add a new effective commit field that has additional logic which is equivalent to https://stackoverflow.com/questions/12671404/latest-commit-hash-of-subdirectory |
Note: this subfolder logic should only apply if Pedantry cornerI guess it's technically possible for tags to be re-pushed, and one of those re-pushes could have a change affecting the subfolder. But I consider this enough of an edge case to say we shouldn't support it. |
Currently if a git repository with a sub folder is used, kpack performs a rebuild even if the subfolder contents are not changed at all.
This is problematic for monorepos with lots of changes. We should support such use cases and only build when necessary.
The text was updated successfully, but these errors were encountered: