sheet.get_all_records() throws index error when sheet has no records

[s2t2]

Describe the bug
sheet.get_all_records() throws an index error when the sheet is blank, or even when the sheet has only a header row with the column names.

To Reproduce
Steps to reproduce the behavior:

1. Make a blank sheet OR make a sheet with only a header row with the column names (but otherwise no records)
2. sheet = doc.worksheet("your-sheet-name")
3. sheet.get_all_records()

Expected behavior
The function should return an empty list, indicating there are no records.

Code example*
see reproduction above

Environment info:

• Operating System [e.g. Linux, Windows, macOS]: mac, linux
• Python version: 3.x
• gspread version: various, including newest 5.12

[lavigne958]

Hi thank you for raising the issue.

We are currently working on this method.

We'll bring a new fix soon.

This reminds me of a special case we used to handle, it looks we don't anymore.

Well fix it and update the tests too.

[lavigne958]

thank @alifeee for taking this issue, I saw your code and checked your branch, I wait for you PR to be ready and will provide the review ASAP.

[alifeee]

Hi. Please read the proposal for changing how get_all_records works for next release 6.0.0 -> #1367. We would enjoy if you would contribute your opinion :)