Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worksheet.delete_row() deprecation #908

Closed
javad94 opened this issue Aug 14, 2021 · 5 comments
Closed

worksheet.delete_row() deprecation #908

javad94 opened this issue Aug 14, 2021 · 5 comments

Comments

@javad94
Copy link
Contributor

javad94 commented Aug 14, 2021

Important: Please do not post usage questions here.
To get a quick response, please ask a question on Stack Overflow using gspread tag.
See existing questions: https://stackoverflow.com/questions/tagged/gspread


Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:
1.
2.
3.

Expected behavior
Deprecation warning in the documentation for delete_row mathod.

Code example*
If applicable, provide a code example to help explain your problem.

Screenshots
image

image

Environment info:

  • Operating System [e.g. Linux, Windows, macOS]:
  • Python version
  • gspread version

Stack trace or other output that would be helpful

Additional context
Is delete_row method deprecated? If yes, then why there's no warning for that in the documentation?

@burnash
Copy link
Owner

burnash commented Aug 14, 2021

Thanks for reporting this. Yes it's deprecated.
Open for a fix.

@javad94
Copy link
Contributor Author

javad94 commented Aug 14, 2021

Thanks for reporting this. Yes it's deprecated.
Open for a fix.

You're very welcome.
I can make a fix, but I need the version of Gspread that this method deprecated.

@burnash
Copy link
Owner

burnash commented Aug 14, 2021

Good point. Let's deprecate it from 5.0.

@javad94
Copy link
Contributor Author

javad94 commented Aug 14, 2021

Good point. Let's deprecate it from 5.0.

Sounds good. Done: #909

@lavigne958
Copy link
Collaborator

closed by #909

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants