Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon #2257

Closed
slugmuffin opened this issue Sep 21, 2017 · 15 comments
Closed

Icon #2257

slugmuffin opened this issue Sep 21, 2017 · 15 comments

Comments

@slugmuffin
Copy link

Add icon for better mobile support. iOS can make a link on home screen, but it's just white for buttonmen right now.

@blackshadowshade
Copy link
Contributor

Does any happen to know the mechanics behind this? Is it just adding an image file of a certain type in a specific location?

@irilyth
Copy link

irilyth commented Sep 21, 2017

https://blog.zen.co.uk/setting-a-home-screen-icon-for-your-website-on-ios-and-android-devices/ suggests that this will work for Android too.

(I'm also amused that the developer.apple.com link above was completely unusable in Chrome/Android. THANKS APPLE.)

@blackshadowshade
Copy link
Contributor

So, it looks like we need a square 144 x 144 px PNG image for this. @AdmiralJota, are you interested in build one of these for us? I'm guessing that the image you used for the favicon would be fine, just bigger.

@blackshadowshade blackshadowshade added this to the Beta milestone Nov 3, 2017
@AdmiralJota
Copy link
Contributor

I believe I have the original Photoshop file I used to build the favicon with. It shouldn't be hard to scale it up.

@AdmiralJota
Copy link
Contributor

bm-icon-144

@blackshadowshade
Copy link
Contributor

Okay, testers, especially @slugmuffin, this is now ready for testing.

Navigate your way to http://ephemeral.dev.buttonweavers.com and try to bookmark various pages from the site, and see if the icon comes up right for you. Let us know on pull request #2286 what platform and software you're testing from, and whether things work for you.

@slugmuffin
Copy link
Author

Looks good to me: screenshot

@irilyth
Copy link

irilyth commented Nov 16, 2017 via email

@irilyth
Copy link

irilyth commented Nov 16, 2017 via email

@blackshadowshade
Copy link
Contributor

So, the actual bookmarky icon will always be the same at the moment, since I only have the one image. Since we know how the icon works, we can probably work out a way to have this different on dev sites, but not at the moment.

As for the actual icon up in the browser bar, dev sites should have red icons, the live site should have a blue icon, and I'm not certain about the staging site.

@blackshadowshade
Copy link
Contributor

According to #2180, the staging favicon should be yellow, since staging_favicon.ico is yellow.

@cgolubi1
Copy link
Contributor

So the question of whether the staging site's icon is misconfigured is worth looking into, but is also kind of a side issue. Where are we on the original topic here?

My two cents is that the primary target audience for the feature under test is prod site users, so if the single icon under test works in the way that will be correct for the prod site, we should merge it, and open a new issue for a phone icon for non-prod sites if there's a target audience who wants that feature. What think?

@blackshadowshade
Copy link
Contributor

Sounds good to me.

@irilyth
Copy link

irilyth commented Nov 20, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants