Staging favicon not being shown

[irilyth]

The staging site is not showing the staging favicon.

[blackshadowshade]

I've just checked, and the staging config table looks like this:

mysql> select * from config;
+-----------+-------------+
| conf_key | conf_value |
+-----------+-------------+
| site_type | development |
+-----------+-------------+
1 row in set (0.00 sec)

Should this should have been set to 'staging' at some stage?

[irilyth]

I don't know, but it looks like the prod favicon in any case.

[blackshadowshade]

Linking #2180, which was the pull request that implemented the changes needed to show the staging favicon.

[blackshadowshade]

So, I discovered today that the selection of the favicon is entirely dependent on the value of Config.siteType (set in Config.js). That should help us track down the incorrect favicon being loaded on staging.

[blackshadowshade]

I've manually changed Config.1586785864.js to have the siteType set to 'staging'. After clearing my JS cache, this fixes this problem, so staging is now showing with the correct favicon and the yellow-backgrounded header.

@cgolubi1 has said that she'll check how her deploy script is setting the Config.siteType, since this is apparently not being set correctly for the dev and staging sites.