Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for HHVM officially? #10674

Closed
ravage84 opened this issue May 19, 2017 · 4 comments
Closed

Drop support for HHVM officially? #10674

ravage84 opened this issue May 19, 2017 · 4 comments
Labels
Milestone

Comments

@ravage84
Copy link
Member

ravage84 commented May 19, 2017

We recently opted out of building the framework on HHVM in Travis CI due to issues with it and seemingly a lack of interest in it: 6339c68

On another note, both Symfony and doctrine will drop their support for HHVM:

facebook/hhvm#7198 (comment)

Related tweets:
https://twitter.com/fabpot/status/865263458903875584
https://twitter.com/fabpot/status/865080534669635584

What is our stance towards supporting HHVM for CakePHP 3.x, 2.x or in general?

Related repo searches on framework, app template and docs:
https://github.com/cakephp/cakephp/search?utf8=%E2%9C%93&q=hhvm&type=
https://github.com/cakephp/app/search?utf8=%E2%9C%93&q=hhvm&type=
https://github.com/cakephp/docs/search?utf8=%E2%9C%93&q=hhvm&type=

@markstory
Copy link
Member

I am 👍 on this. We haven't had passing tests on HHVM in 6+ months. I don't think we can say we 'support' it if our tests can't pass.

@markstory markstory added this to the 3.5.0 milestone May 19, 2017
@lorenzo
Copy link
Member

lorenzo commented May 21, 2017

We never had 100% tests passing in hhvm. We tried, though

@markstory
Copy link
Member

Given the features of PHP we use, HHVM didn't make it easy to get to 💯

@ravage84
Copy link
Member Author

ravage84 commented Jun 1, 2017

I understand your responses and reactions as a clear Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants