Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated code in components affecting StackBlitz integration #18546

Open
5 tasks
heloiselui opened this issue Feb 10, 2025 · 0 comments
Open
5 tasks

Outdated code in components affecting StackBlitz integration #18546

heloiselui opened this issue Feb 10, 2025 · 0 comments

Comments

@heloiselui
Copy link
Contributor

heloiselui commented Feb 10, 2025

Package:
@carbon/react

Description:

While working on the StackBlitz integration for components in carbon/react, we encountered issues with some components when trying to include StackBlitz. During a PR review and pairing session, we noticed that the code is outdated and needs to be updated to align with the current implementation.

Remove the .bind in each story file!!!!! look at the other files for reference

Components to be updated:

  • IconButton
  • Pagination
  • PaginationNav
  • Toggle
  • Toggletip

Expected Outcome:

These components should be updated to follow the latest standards and ensure proper functionality within StackBlitz.

Additional Context:

This issue was identified during a PR review meeting, and the outdated code is causing difficulties in integrating StackBlitz 18344. Updating these components will improve our carbon page and maintainability.

For reference, the Accordion component is functioning as expected and can be used as a model for the necessary updates. The integration with StackBlitz works well with this component, so aligning the others with this approach should resolve the issue.

Additionally, in the codePreview.tsx file, you can check the rules and adjustments we apply to ensure that Storybook code is transformed correctly into a format that StackBlitz can interpret. This file contains key logic for proper integration and should provide insights into the required adjustments for the components mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ⏱ Backlog
Development

No branches or pull requests

2 participants