Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parsing of 64bit PE in readImports #65

Open
igascr opened this issue Apr 20, 2020 · 1 comment
Open

Incorrect parsing of 64bit PE in readImports #65

igascr opened this issue Apr 20, 2020 · 1 comment

Comments

@igascr
Copy link

igascr commented Apr 20, 2020

Incorrect import entries added due to incorrect parsing in

for ; ; importThunk += 4 {

importThunk is incremented 4 bytes instead of 8 bytes for 64bit binaries.

@jholowczak
Copy link
Collaborator

Hello,

What timing! At the time of this report we were prepping to merge in work to add 64 bit PE support to binee, so some of the code that existed was stale and not a correct implementation. We just merged in the 64-bit support to master, which includes a fix for this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants