Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receiving XEP-0337 message stanzas cause an empty message to appear in chatList #334

Closed
sylae opened this issue Mar 16, 2016 · 3 comments
Closed

Receiving XEP-0337 message stanzas cause an empty message to appear in chatList #334

sylae opened this issue Mar 16, 2016 · 3 comments
Labels
duplicate
Milestone
1.11.0 - Nightmare

Comments

@sylae
Copy link
Contributor

sylae commented Mar 16, 2016

I am currently getting ligrev to beam event logs over XMPP (see this issue). Example stanza below:

<body xmlns='http://jabber.org/protocol/httpbind'>
  <message xmlns='jabber:client' from='[email protected]/jaxl#6056e12474bcd47b2ea9e3d61c225b22' to='[email protected]' xml:lang='en' type='chat'>
    <log xmlns='urn:xmpp:eventlog' timestamp='2016-03-16T11:11:19+00:00' type='Debug' module='JAXL'>
      <message>Connected to XMPP Server</message>
      <tag name='jid' value='[email protected]/jaxl#6056e12474bcd47b2ea9e3d61c225b22' type='xs:string'/>
      <tag name='git' value='f6140a5ce0beefb3a2dc94f065c620151ac30d31'/>
      <tag name='file' value='/home/sylae/ligrev/ligrev.php'/>
      <tag name='line' value='25'/>
      <tag name='class'/>
      <tag name='function' value='Ligrev\{closure}'/>
    </log>
    <!-- optionally, more log elements -->
  </message>
</body>

Output received:

(05:11:25) [email protected]: (whispers)

Presumably, this happens with any XEP that "extends" <message />.

Now, what would be really nifty is having Cadence display the debug info (with a config switch to turn off output when not debugging) but I doubt that would ever be used by literally anyone but me.

A more reasonable fix: If a message contains neither a <body /> element not a <html><body /></html> element, don't display anything.
@cburschka
Copy link
Owner

Yeah, there's a related issue with another message extension, let me find it.

@cburschka
Copy link
Owner

Right, #201 (Chat State), and the "ignore <body />-less message" fix was in #313. Looks like it's already fixed in 1.11.

@cburschka cburschka added this to the 1.11.0 - Nightmare milestone Mar 16, 2016
@cburschka
Copy link
Owner

71d898b

Versions after this commit should ignore the message; going to close for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
1.11.0 - Nightmare
Development

No branches or pull requests
2 participants
@cburschka @sylae