Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Bug fix logo showing on mobile (fixes #20) #21

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix: Bug fix logo showing on mobile (fixes #20) #21

merged 1 commit into from
Jan 30, 2024

Conversation

guywillis
Copy link
Contributor

Fixes: #20

Fix

  • Ensure page loads course level config for _hideLogoForMobile

@guywillis guywillis added the bug label Jan 29, 2024
@guywillis guywillis self-assigned this Jan 29, 2024
kirsty-hames
kirsty-hames approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks @guywillis.

swashbuck
swashbuck approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@guywillis guywillis merged commit 66aef8b into master Jan 30, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
@semantic-release-bot
Chore(release): 3.1.1 [skip ci]
2a2ee06 
## [3.1.1](v3.1.0...v3.1.1) (2024-01-30)

### Fix

* Bug fix logo showing on mobile on pages (fixes #20) #21 ([66aef8b](66aef8b)), closes [#20](#20) [#21](#21)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@guywillis guywillis deleted the issue/20 branch January 30, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swashbuck swashbuck

@kirsty-hames kirsty-hames

Assignees

@guywillis guywillis

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check course level mobile display config
3 participants
@guywillis @swashbuck @kirsty-hames