Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

[BUG] Task Failure Alert for KPIs with Empty Sub-dimension List After Editing #938

Closed
athul-osmo opened this issue Apr 27, 2022 · 1 comment
Assignees
Labels
🛠️ backend 🐛 bug Something isn't working
Milestone

Comments

@athul-osmo
Copy link

Describe the bug

The bug occurs when a KPI is edited and all existing sub-dimensions are completely removed so no sub-dimension is being ran for anomaly detection for a KPI.

Explain the environment

  • Chaos Genius version: 0.6.1
  • OS Version / Instance: macOS Big Sur 11.6.3
  • Deployment type: setup from scratch

Current behavior

If a KPI is set up without sub-dimensions in the first place this error does not come up. However, after editing an existing KPI by removing all sub-dimensions, this task failure appears saying ValueError: No group keys passed! .

Expected behavior

When a KPI is edited to remove all sub-dimensions (in the case we do not want anomaly detection for sub-dimensions), it should allow us to give no keys for sub-dimensions without producing an error, or there should be an option to not run anomaly detection on sub-dimensions.

Screenshots

image
The task failure csv returned for one of the KPIs with this issue.

Additional context

We recreated the KPI from scratch without including any sub-dimensions and there were no task failures raised.

Logs

Provided in Expected Behavior section.

@manassolanki
Copy link
Member

@varunp2k Can you please have a look at this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠️ backend 🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants