request: add 'success' log level

[KyleTryon]

Example

log.Success("Complete!")

Where the output in this case would be green and have a prefix similar to SUCC.

This would be at the same level as "Info" but offer an alternative style

[damongolding]

I would like this too!

[plastikfan]

I have just discovered the glorious charm universe and the logging aspect has drawn my attension as I'm looking to integrate charm's log into some of my own projects. I noticed this issue, which initially seemed like a good idea, but after I did a little research, I came to conclusion that it is not and the reason is standards. Logging has a long history and has evolved from standards, in particluar, the syslog standard and also see RFC-5424. Actually I found a very good blog post: logging levels explained that may interest you. If you need a custom new non standard log level (even if its just a synonym for INFO), then it would be unadvisbable to implement in charm, it would be better for you to do this in a fork and doing so in charm would encourage third parties to become dependent on non standard functionality.

If any change is made, then the TRACE level could be added as that is in the standard, but I get it, this won't help your use case.

[eko234]

Hello, I have a similar usecase, but I think a workaround maybe to allow the kv pairs to overwrite the level maybe? it could be opt in with a new option from the config, I will work it out some other way but just wanted to let this idea.

[aymanbagabas]

Hi everyone! With the changes introduced in #95, you can now define your custom level and wrap the logger with your type to achieve the same behavior. Take a look at this example
Keep in mind that these changes are still in main and will be part of the new release v0.4.0 soon 🙂

[aymanbagabas]

Log v0.4.0 is out now! closing...

[adamscybot]

I just wanted to add a note here that for full functionality, you can also override With and WithPrefix; otherwise, using those methods returns a base charm bracelet logger and not your modified one.

Here's how that is in my wrapper that adds a trace level:

package log

import (
	"os"

	"github.com/charmbracelet/lipgloss"
	"github.com/charmbracelet/log"
)

const TraceLevel = log.DebugLevel - 1

type Logger struct {
	*log.Logger
}

func (l *Logger) Trace(msg string, args ...any) {
	l.Log(TraceLevel, msg, args...)
}

func (l *Logger) With(keyvals ...interface{}) *Logger {
	return &Logger{l.Logger.With(keyvals...)}
}

func (l *Logger) WithPrefix(prefix string) *Logger {
	return &Logger{l.Logger.WithPrefix(prefix)}
}

func NewLogger() *Logger {
	l := new(Logger)
	logger := log.New(os.Stderr)
	styles := log.DefaultStyles()
	styles.Levels[TraceLevel] = lipgloss.NewStyle().
		SetString("TRACE").
		Bold(true).
		MaxWidth(4).
		Foreground(lipgloss.Color("61"))
	logger.SetStyles(styles)
	l.Logger = logger
	return l
}