Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make custom BaseAuthHandler and BaseAgent classes sync #958

Closed
pieroit opened this issue Oct 28, 2024 · 2 comments
Closed

Make custom BaseAuthHandler and BaseAgent classes sync #958

pieroit opened this issue Oct 28, 2024 · 2 comments
Assignees
Labels
agent Related to cat agent (reasoner / prompt engine) async/await Tasks and issues related to asynchronous programming, async functions, and await syntax. enhancement New feature or request

Comments

@pieroit
Copy link
Member

pieroit commented Oct 28, 2024

No more async in core classes and plugin primitives, as it is not necessary and the performance advantage is not worth the maintaining effort. See here for more context.

Take away async/await from auth handlers and agent classes.
If somebody is available to do it, comment and I will assign the issue.

Hugs

@pieroit pieroit added enhancement New feature or request agent Related to cat agent (reasoner / prompt engine) async/await Tasks and issues related to asynchronous programming, async functions, and await syntax. labels Oct 28, 2024
@lucagobbi lucagobbi self-assigned this Nov 17, 2024
@lucagobbi
Copy link
Collaborator

I have a PR ready for this, but I have one question: unlike the BaseAgent, which is entirely internal, removing async from the auth handlers would introduce a breaking change for developers who have implemented custom auth handlers async. Should we merge it in v2?

@pieroit
Copy link
Member Author

pieroit commented Nov 17, 2024

I have a PR ready for this, but I have one question: unlike the BaseAgent, which is entirely internal, removing async from the auth handlers would introduce a breaking change for developers who have implemented custom auth handlers async. Should we merge it in v2?

Let's break it now, I'll merge and give note about this when 1.8 is released

Thanks @lucagobbi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Related to cat agent (reasoner / prompt engine) async/await Tasks and issues related to asynchronous programming, async functions, and await syntax. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants