Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What does "Config resolution strategy" do? #775

Closed
real-or-random opened this issue Feb 2, 2021 · 6 comments
Closed

What does "Config resolution strategy" do? #775

real-or-random opened this issue Feb 2, 2021 · 6 comments
Labels

Comments

@real-or-random
Copy link

Question

What does "Config resolution strategy" do? I can't find documentation on it.

@fkorotkov
Copy link
Contributor

Will think where to put it in the docs and in the meantime you can check my comment here #662 (comment) which should explain the options. Please let me know if it's not clear.

@real-or-random
Copy link
Author

Ha, it was our parent project asking for that option of course.

I think I get what this is doing but Target Branch was replaced by Merge for PRs (which is indeed better if this does what I believe it does).

Am I right that Merge for PRs applies only to the config and not to the rest of the repo? So we'd still need the workaround in #662 (comment) to run CI on the merged code instead of on the PR branch?

@fkorotkov
Copy link
Contributor

Yeah. Only for the config. IMO it's a tricky question for tasks especially when there are dependencies. Always using the merged version can result in tasks using different versions of source code.

Imagine, there is task foo and bar which depends on foo and while foo was executing there was a new commit to the target branch. In this case bar will pick up the new commit.

Ideally, I wish there was a way to do a rebase upon PR creation and before any tasks is executed.

@fkorotkov
Copy link
Contributor

Closing as answered.

@real-or-random
Copy link
Author

Will think where to put it in the docs

Is this done? (Just checking, feel free to close but I thought it's a good idea to keep this open as a reminder.)

@fkorotkov
Copy link
Contributor

@real-or-random for cloning merged code please subscribe to #791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants