fix: wait until deployment stabilizes to set status Ready

Signed-off-by: Mario Valderrama <[email protected]>

Author: avorima

internal/resources/k8s_deployment_resource.go

@@ -8,6 +8,7 @@ import (
 
 	appsv1 "k8s.io/api/apps/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/utils/ptr"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
 
@@ -102,10 +103,24 @@ func (r *KubernetesDeploymentResource) isProgressingUpgrade() bool {
 		return true
 	}
 
+	// An update is complete when new pods are ready and old pods deleted.
+	desired := ptr.Deref(r.resource.Spec.Replicas, 2)
 	if r.resource.Status.UnavailableReplicas > 0 {
 		return true
 	}
 
+	if r.resource.Status.UpdatedReplicas != desired {
+		return true
+	}
+
+	if r.resource.Status.ReadyReplicas != desired {
+		return true
+	}
+
+	if r.resource.Status.Replicas != desired {
+		return true
+	}
+
 	return false
 }