Skip to content

Commit 67c7047

Browse files
author
Nathan
authored
Merge pull request #3790 from cloudfoundry-incubator/remove-dupe-reducer
Remove duplicate current-user reducer
2 parents 4cad165 + 5b0b046 commit 67c7047

File tree

7 files changed

+21
-208
lines changed

7 files changed

+21
-208
lines changed

src/frontend/packages/cloud-foundry/src/store/reducers/current-user-roles-reducer/current-user-role-session.reducer.ts

-91
This file was deleted.

src/frontend/packages/store/src/reducers/current-user-roles-reducer/current-user-roles-changed.reducers.ts src/frontend/packages/cloud-foundry/src/store/reducers/current-user-roles-reducer/current-user-roles-changed.reducers.ts

+8-16
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,11 @@
1-
import { ChangeUserRole } from '../../../../cloud-foundry/src/actions/users.actions';
2-
import {
3-
defaultUserOrgRoleState,
4-
} from '../../../../cloud-foundry/src/store/reducers/current-user-roles-reducer/current-user-roles-org.reducer';
5-
import {
6-
defaultUserSpaceRoleState,
7-
} from '../../../../cloud-foundry/src/store/reducers/current-user-roles-reducer/current-user-roles-space.reducer';
8-
import {
9-
ICfRolesState,
10-
IOrgRoleState,
11-
ISpaceRoleState,
12-
} from '../../../../cloud-foundry/src/store/types/cf-current-user-roles.types';
13-
import { PermissionStrings } from '../../../../core/src/core/current-user-permissions.config';
14-
import { ICurrentUserRolesState } from '../../types/current-user-roles.types';
15-
import { APISuccessOrFailedAction } from '../../types/request.types';
16-
import { OrgUserRoleNames, SpaceUserRoleNames } from '../../../../cloud-foundry/src/store/types/user.types';
1+
import { PermissionStrings } from '../../../../../core/src/core/current-user-permissions.config';
2+
import { ICurrentUserRolesState } from '../../../../../store/src/types/current-user-roles.types';
3+
import { APISuccessOrFailedAction } from '../../../../../store/src/types/request.types';
4+
import { ChangeUserRole } from '../../../actions/users.actions';
5+
import { ICfRolesState, IOrgRoleState, ISpaceRoleState } from '../../types/cf-current-user-roles.types';
6+
import { OrgUserRoleNames, SpaceUserRoleNames } from '../../types/user.types';
7+
import { defaultUserOrgRoleState } from './current-user-roles-org.reducer';
8+
import { defaultUserSpaceRoleState } from './current-user-roles-space.reducer';
179

1810
export function updateAfterRoleChange(
1911
state: ICurrentUserRolesState,

src/frontend/packages/cloud-foundry/src/store/reducers/current-user-roles-reducer/current-user-roles-orgs.reducer.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
1+
import {
2+
addNewRoles,
3+
removeOldRoles,
4+
} from '../../../../../store/src/reducers/current-user-roles-reducer/current-user-reducer.helpers';
15
import { GetCurrentUserRelationsComplete } from '../../../actions/permissions.actions';
26
import { IOrgsRoleState } from '../../types/cf-current-user-roles.types';
3-
import { addNewRoles, removeOldRoles } from '../../../../../store/src/reducers/current-user-roles-reducer/current-user-reducer.helpers';
47
import { currentUserOrgRoleReducer } from './current-user-roles-org.reducer';
58

69
export function currentUserOrgRolesReducer(state: IOrgsRoleState = {}, action: GetCurrentUserRelationsComplete) {

src/frontend/packages/cloud-foundry/src/store/reducers/current-user-roles-reducer/current-user-roles-space.reducer.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import { UserRelationTypes } from '../../../actions/permissions.actions';
1+
import { ISpace } from '../../../../../core/src/core/cf-api.types';
22
import { APIResource } from '../../../../../store/src/types/api.types';
3+
import { UserRelationTypes } from '../../../actions/permissions.actions';
34
import { ISpaceRoleState } from '../../types/cf-current-user-roles.types';
4-
import { ISpace } from '../../../../../core/src/core/cf-api.types';
55

66
export const defaultUserSpaceRoleState: ISpaceRoleState = {
77
orgId: null,

src/frontend/packages/cloud-foundry/src/store/reducers/current-user-roles-reducer/current-user-roles-spaces.reducer.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
1+
import {
2+
addNewRoles,
3+
removeOldRoles,
4+
} from '../../../../../store/src/reducers/current-user-roles-reducer/current-user-reducer.helpers';
15
import { GetCurrentUserRelationsComplete } from '../../../actions/permissions.actions';
26
import { ISpacesRoleState } from '../../types/cf-current-user-roles.types';
3-
import { addNewRoles, removeOldRoles } from '../../../../../store/src/reducers/current-user-roles-reducer/current-user-reducer.helpers';
47
import { currentUserSpaceRoleReducer } from './current-user-roles-space.reducer';
58

69
export function currentUserSpaceRolesReducer(state: ISpacesRoleState = {}, action: GetCurrentUserRelationsComplete) {

src/frontend/packages/cloud-foundry/src/store/reducers/current-user-roles-reducer/current-user-roles.reducer.ts

-96
This file was deleted.

src/frontend/packages/store/src/reducers/current-user-roles-reducer/current-user-roles.reducer.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ import { ADD_ROLE_SUCCESS, REMOVE_ROLE_SUCCESS } from '../../../../cloud-foundry
1717
import {
1818
currentUserBaseCFRolesReducer,
1919
} from '../../../../cloud-foundry/src/store/reducers/current-user-roles-reducer/current-user-base-cf-role.reducer';
20+
import {
21+
updateAfterRoleChange,
22+
} from '../../../../cloud-foundry/src/store/reducers/current-user-roles-reducer/current-user-roles-changed.reducers';
2023
import { SESSION_VERIFIED, VerifiedSession } from '../../actions/auth.actions';
2124
import {
2225
CONNECT_ENDPOINTS_SUCCESS,
@@ -32,7 +35,6 @@ import {
3235
currentUserRolesRequestStateReducer,
3336
} from './current-user-request-state.reducers';
3437
import { roleInfoFromSessionReducer, updateNewlyConnectedEndpoint } from './current-user-role-session.reducer';
35-
import { updateAfterRoleChange } from './current-user-roles-changed.reducers';
3638
import { addEndpoint, removeEndpointRoles, removeOrgRoles, removeSpaceRoles } from './current-user-roles-clear.reducers';
3739

3840
const getDefaultState = () => ({

0 commit comments

Comments
 (0)