-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Tests Time::humanize()
does not work with ar
locale
#9478
Comments
I am not an Arabic speaker, but in any case, I don’t see any issue. The output for me is as follows: $time->humanize() UTF-8 string (20) "منذ ١ أسبوع" which seems correct. |
|
I found solution. Update locale as ar@numbers=arab Do I need to update the tests, or will we rely on everyone's system (ICU) being configured as on Github Actions? My version intl: ICU version 76.1
ICU Data version 76.1
ICU TZData version 2024b
ICU Unicode version 16.0 |
Does the ICU version impact the default settings for the If |
Okay, I did some deeper digging, and it turns out this change was introduced in ICU 76 (released on October 24, 2024). The modification came from CLDR 46, where the default numbering system for If you're interested in this, please send a PR which will change the locale from |
PHP Version
8.4
CodeIgniter4 Version
4.6
CodeIgniter4 Installation Method
Git
Which operating systems have you tested for this bug?
Linux
Which server did you use?
cli-server (PHP built-in webserver)
Database
No response
What happened?
PHP 8.4.4 has made some changes.
Steps to Reproduce
Run the tests on local PC: Arch, PHP 8.4.4.
List locales:
Expected Output
Successful completion of the tests is expected
Anything else?
I don't use specific languages, maybe @datamweb can tell us.
Old PR here: #6120
The text was updated successfully, but these errors were encountered: