Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need some clarification on Specifications #82

Closed
sambacha opened this issue Jul 24, 2020 · 1 comment
Closed

Need some clarification on Specifications #82

sambacha opened this issue Jul 24, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@sambacha
Copy link

sambacha commented Jul 24, 2020

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
see this

Describe the solution you'd like
A clear and concise description of what you want to happen.

Please provide guidance on the issues I have submitted here: coinbase/mesh-specifications#23

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Stop all development on this "rosetta" thing
Additional context
Add any other context or screenshots about the feature request here.

I have a few questions/requests for clarification as to your specification

Amount.yaml

Amount is described as:

Amount is some Value of a Currency

Can it be changed to:

Amount is some Unit of Account

currency has legal implications, and strictly speaking, this is not entirely accurate for EVM chains as gas is the unit of account for EVM chains (typically) whereas ethereum

Account Identifier

currently reads:

  • The account_identifier uniquely identifies an account within a network.

can it be expanded to fit a more approximate meaning of the word? As you can have a chain that uses the same derivation path in both instances but have assets in different addresses.

Also, can this be explicit in what it means as to what constitutes an "account"? Is it only EOA - Externally owned accounts only or can smart contract addresses be included with no distinction?

informative ref: eip1191.

example:

const hexChecksumChain = (name: string, coinType: number, chainId?: number) => ({
  coinType,	  coinType,
  decoder: decodeChecksummedHex,	  decoder: makeChecksummedHexDecoder(chainId),
  encoder: encodeChecksummedHex,	  encoder: makeChecksummedHexEncoder(chainId),
  name,	  name,
});	});

example ref: ensdomains/address-encoder/commit/5bf53b13fa014646ea28c9e5f937361dc9b40590

Network Identifer.yaml

The network_identifier specifies which network a particular object is associated with.

"If a blockchain has a specific chain-id or network identifier, it
should go in this field."

Can we also provide an (optional) direct link to a repository containing the genesis file? This would be the least ambiguous as to
** Informative ** ethereum-listss/chains

Additional references and sources can be made available. A Java SDK would be trivial, I just would like to not have to make awkward choices if possible, these are the ones just most apparent.

Thank you.

@sambacha sambacha added the enhancement New feature or request label Jul 24, 2020
@patrick-ogrady
Copy link
Contributor

Sorry for the delay in responding here @sambacha : coinbase/mesh-specifications#23 (comment)

Closing the issue on this repo as it is better suited for rosetta-specifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants