Skip to content
This repository was archived by the owner on Nov 24, 2021. It is now read-only.

[Suggestion] Declare a connection dead faster using the PING feature #18

Open
colonelwatch opened this issue Jul 30, 2021 · 0 comments
Open

Comments

@colonelwatch
Copy link
Owner

Thanks for all the logs and screenshots, it's useful information. I can reproduce the same problem on my computer. Maybe it's some kind of bug on the server that's interacting with third-party programs? I should open an issue on the duino-coin repository, I suppose.

Yes, but the problem is that it is not output in the system encoding by default. I needed to do setlocale (LC_ALL, "") for it to work correctly.

Oh, I didn't know about this! If setlocale is all it needs, then I could accept that change. Otherwise, language programming and translation is not something I plan to get into any time soon, so I might just default the error code interpretations to English. What do you think?

I also found another bug, the message about the hash is duplicated if there were no acceptances

Regarding the bug, that was something I had to accept back when I was writing that part of the program. At the time, a dead connection and a live connection were indistinguishable, and all you could do was assume it was dead when the timeout expires. The natural result of that is that the hashrate counter cannot be cleared until the connection has been declared dead. Nowadays, there's this ping feature in the mining protocol that can prove a connection is dead or not much quicker, maybe I'll try implementing it one day? I'll open an issue regarding that.

Originally posted by @colonelwatch in #17 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant