Skip to content
This repository was archived by the owner on Mar 23, 2021. It is now read-only.

Make the build fail on warnings during testing on Travis #301

Closed
thomaseizinger opened this issue Sep 26, 2018 · 3 comments
Closed

Make the build fail on warnings during testing on Travis #301

thomaseizinger opened this issue Sep 26, 2018 · 3 comments
Labels
good first issue Good for newcomers

Comments

@thomaseizinger
Copy link
Contributor

With the merge of #300, we have a lot of warnings in our code base.

These should obviously be fixed.

Once that is done, we should find a way to fail the CI build on warnings.

@thomaseizinger
Copy link
Contributor Author

This code shows how this can be done with clippy: https://github.com/rust-lang-nursery/rust-clippy#travis-ci

Open questions:

  • Does clippy also emit warnings generated by rustc? If yes, then we can simply use clippy to fail the build upon any warnings.

@thomaseizinger
Copy link
Contributor Author

cargo fix will eventually be able to fix clippy warnings, we can thus ignore them for now and fix them automatically later.

Source: rust-lang/rustfix#130

@D4nte
Copy link
Contributor

D4nte commented Feb 3, 2019

Done!

@D4nte D4nte closed this as completed Feb 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants