Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid not enough storage error #111

Open
andiradulescu opened this issue Feb 24, 2025 · 1 comment
Open

Invalid not enough storage error #111

andiradulescu opened this issue Feb 24, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@andiradulescu
Copy link
Collaborator

andiradulescu commented Feb 24, 2025

If I comment out the exception throwing, flashing works perfectly fine.

I suggest this check to be non-blocking - more like a warning that you can skip.

Can be reproduced in Brave Browser on macOS.

Image Image
@andiradulescu andiradulescu changed the title Not enough storage: 2048MB free, need 5250MB Invalid not enough storage error Feb 24, 2025
@incognitojam
Copy link
Member

Hmm they made this report a false number to avoid fingerprinting (capped at 2GB) brave/brave-core#6622

The real solution here is to use less storage space, which we can do by not saving the unpacked images, just stream the unpacked bytes to flash

@incognitojam incognitojam added the bug Something isn't working label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants