Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

athena: setup upload priority #34836

Open
nelsonjchen opened this issue Mar 10, 2025 · 2 comments
Open

athena: setup upload priority #34836

nelsonjchen opened this issue Mar 10, 2025 · 2 comments

Comments

@nelsonjchen
Copy link
Contributor

nelsonjchen commented Mar 10, 2025

As a comma connect user, I would like my human-initiated "interactive" uploads prioritized over automated Firehose Mode uploads so it feels more responsive.

  1. Have Firehose mode on (or I suspect just being on a branch of great interest to comma)
  2. Automated Firehose mode segments are queued for upload.
  3. Go to comma Connect, choose upload files or segments.
  4. View Uploads for device, see the human chosen upload files or segments are queued behind automated firehose segments. This can be a 5-10 segment delay before the human chosen segments are finally uploaded.

Workaround: Cancel All Segments and requeue desired segments for upload.

@adeebshihadeh
Copy link
Contributor

Bounty is for setting up the priority-based upload in athena.

Must have a good unit test around it.

@adeebshihadeh adeebshihadeh changed the title Automated Firehose Mode uploads at the same priority in the queue as human-initiated interactive uploads athena: setup upload priority Mar 10, 2025
@greatgitsby
Copy link

greatgitsby commented Mar 11, 2025

this can't be achieved w/o passing the "intent" or requester to athenad (intent = Intent.COMMA_CONNECT | Intent.FIREHOSE).

is this something that can be added on the connect / firehose service backends?

EDIT: i see supported params are defined by athenad. impl can be done before the private backends are updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Open
Development

No branches or pull requests

3 participants