Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comma3X product photo to not have nav UI #14

Open
ugtthis opened this issue Feb 15, 2025 · 4 comments
Open

Update comma3X product photo to not have nav UI #14

ugtthis opened this issue Feb 15, 2025 · 4 comments

Comments

@ugtthis
Copy link
Contributor

ugtthis commented Feb 15, 2025

Alexandre from Discord pointed this out here

Image

Ways to go about this:

  • I could drop in a different road scene that doesn't have the nav UI but it would not match the hero shot of the comma3X on the site
  • If you guys have the image of the road I can use that image and photoshop that onto the device (ideal scenario)
  • Provide the route ID so I could replay it on my machine and screenshot the UI of when it gets to that part of the road that matches the current image
@adeebshihadeh
Copy link
Collaborator

@sshane might happen to have the route, but I couldn't find it or even the source for this image in our Figma.

Feel free to just replace it with a nice replay. Maybe the openpilot demo route has something nice?

@sshane
Copy link
Contributor

sshane commented Feb 15, 2025

It's from the EV6 demo route, I can try to find it

@ugtthis
Copy link
Contributor Author

ugtthis commented Feb 16, 2025

Feel free to just replace it with a nice replay.

If I change this to another route, the device route UI would not match the the device-backdrop.jpg found here. The 2 places the device-backdrop.jpg is used is in https://comma.ai/shop, and https://comma.ai/vehicles. Technically comma.ai/vehicles uses cover-vehicles-v2-3x-optimized_1.jpg(found here) which is just the backdrop photo + the comma3x device in it.

So if we wanted to go down the path of changing the specific route UI on the device then we would also need to change the device-backdrop.jpg. Or we can stop using the backdrop image on the site, which then changing the route UI on device to any route would work.

Screenshot of device-backdrop.jpg

Image

@ugtthis
Copy link
Contributor Author

ugtthis commented Feb 16, 2025

I tried to use device-backdrop.jpg and crop out a portion of the background to then photoshop in to the device but the photo doesn't have enough pixels so it does not looks as good versus getting the actual route video

Comparing the draft edit and current UI

comparing-edits.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants