Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProTrace mod #684

Open
Soph1514 opened this issue Feb 19, 2025 · 9 comments · May be fixed by #715
Open

ProTrace mod #684

Soph1514 opened this issue Feb 19, 2025 · 9 comments · May be fixed by #715
Assignees

Comments

@Soph1514
Copy link
Contributor

Soph1514 commented Feb 19, 2025

An idea for internal implementation for all the tracing functionality in a form of a Rust module ProTrace.
The first draft of the design document is linked below.

DesignDoc (ProTrace).docx

@YuxinZhang214
Copy link

I have no idea what this is, but I am happy to help :D

@Soph1514
Copy link
Contributor Author

I am glad to hear it! Would be more than happy to explain my ideas and also go through existing tracing functionality.

@YuxinZhang214
Copy link

Yeah, sure! Please go ahead

@Soph1514
Copy link
Contributor Author

Wait sorry, I was meant to assign this to someone else.

@Soph1514
Copy link
Contributor Author

Soph1514 commented Feb 21, 2025

Really sorry for the confusion. But if you also want to get involved, I would be more than happy to talk to you. Are you a part this semester VIP team or previous ones?

@YuxinZhang214
Copy link

No worries at all! I’d love to get involved. I thought this might be really interesting. I’m not part of the VIP team this semester, but I was maintaining the CP demos before.

I saw the documentation above. Would you like to walk me through your implementation or anything?

@ChrisJefferson
Copy link
Contributor

One small thought (and I'm not saying do this, it's just a thought :) )

Do you want to be able to report the "kind" of message, as well as the verbosity level? Lots of tracing libraries support the ability to specify the 'type' of message, someone might (for example) want to see all the rules to do with type refinement, but nothing else.

I don't know in this case if it's worth trying to sort messages by both verbosity and kind, but it possible worth thinking about it and explictly saying it isn't happening :)

@Soph1514
Copy link
Contributor Author

One small thought (and I'm not saying do this, it's just a thought :) )

Do you want to be able to report the "kind" of message, as well as the verbosity level? Lots of tracing libraries support the ability to specify the 'type' of message, someone might (for example) want to see all the rules to do with type refinement, but nothing else.

I don't know in this case if it's worth trying to sort messages by both verbosity and kind, but it possible worth thinking about it and explictly saying it isn't happening :)

O, that is a good idea! I will definitely add it as a potential future feature.

@Soph1514
Copy link
Contributor Author

No worries at all! I’d love to get involved. I thought this might be really interesting. I’m not part of the VIP team this semester, but I was maintaining the CP demos before.

I saw the documentation above. Would you like to walk me through your implementation or anything?

Are you still in St Andrews?

@Soph1514 Soph1514 linked a pull request Mar 11, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants