Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve proper way to handle tags/versioning of action #2

Open
estesp opened this issue Dec 3, 2020 · 2 comments
Open

Resolve proper way to handle tags/versioning of action #2

estesp opened this issue Dec 3, 2020 · 2 comments

Comments

@estesp
Copy link
Member

estesp commented Dec 3, 2020

See this comment for the canonical (?) way to handle making small fixes while allowing consumers to still use a "major" reference like v1: https://github.ghproxy.topmunity/t/version-numbering-for-actions/16307/5

@estesp
Copy link
Member Author

estesp commented Dec 3, 2020

Would love your thoughts here @mxpv ; I created a v1.0.1 tag to make progress on the website repo using this action, but don't want to make too much mess before we figure out how to handle small fixes in the future.

@mxpv
Copy link
Member

mxpv commented Dec 3, 2020

I think the suggestion you referenced is a good one, I haven't seen before.
In current approach with tags, every time we make a new release (like v1.0.1), we have to repush v1 tag to point it from v1.0.0 to v1.0.1, so runners pick up a new change. In case of v1 branch we don't have to do that, but rather just push a change directly to that branch.
Otherwise we just push stuff to master branch and it won't be picked up by anyone (unless there is containerd/project-checks@master somewhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants