Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a slogAdapter converting go-kit/log to slog #6402

Closed
SungJin1212 opened this issue Dec 5, 2024 · 2 comments · Fixed by #6405
Closed

Add a slogAdapter converting go-kit/log to slog #6402

SungJin1212 opened this issue Dec 5, 2024 · 2 comments · Fixed by #6405
Labels
type/chore Something that needs to be done; not a bug or a feature

Comments

@SungJin1212
Copy link
Member

The Prometheus v3.0.0 uses a slog instead of the go-kit/log. In other words, the passed log parameter is changed to slog.
To upgrade Prometheus v3.0.0, we should pass slog instead of go-kit/log.

So, it might be good to implement a slogAdapter which converts go-kit/log to slog.

@dosubot dosubot bot added the type/chore Something that needs to be done; not a bug or a feature label Dec 5, 2024
@yeya24
Copy link
Contributor

yeya24 commented Dec 5, 2024

FYI we probably need to update the common library to support slog there. https://github.com/cortexproject/weaveworks-common/tree/master/logging

We can try the adapter approach https://github.com/tjhop/slog-gokit first and see if it is good enough.

@CharlieTLe
Copy link
Member

Might be a good opportunity to see if we can use OpenTelemetry-go for logging here as the api and use slog as the sdk. Benefits include standardization of logging and exemplar support with traces.

@SungJin1212 SungJin1212 mentioned this issue Dec 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Something that needs to be done; not a bug or a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants