Review feedback

alpe · alpe · commit 4dd80706507c · 2025-01-13T10:34:55.000+01:00
diff --git a/simapp/v2/sim_runner.go b/simapp/v2/sim_runner.go
@@ -166,7 +166,8 @@ func SetupTestInstance[T Tx, V SimulationApp[T]](
 }
 
 // InitializeChain sets up the blockchain with an initial state, validator set, and history using the provided genesis data.
-func (ti TestInstance[T]) InitializeChain(tb testing.TB,
+func (ti TestInstance[T]) InitializeChain(
+	tb testing.TB,
 	ctx context.Context,
 	chainID string,
 	genesisTimestamp time.Time,
diff --git a/simapp/v2/sim_test.go b/simapp/v2/sim_test.go
@@ -13,7 +13,7 @@ import (
 	"github.com/stretchr/testify/require"
 
 	simtypes "github.com/cosmos/cosmos-sdk/types/simulation"
-	v2 "github.com/cosmos/cosmos-sdk/x/genutil/v2"
+	genutil "github.com/cosmos/cosmos-sdk/x/genutil/v2"
 	simcli "github.com/cosmos/cosmos-sdk/x/simulation/client/cli"
 )
 
@@ -59,7 +59,7 @@ func TestAppStateDeterminism(t *testing.T) {
 
 // ExportableApp defines an interface for exporting application state and validator set.
 type ExportableApp interface {
-	ExportAppStateAndValidators(forZeroHeight bool, jailAllowedAddrs []string) (v2.ExportedApp, error)
+	ExportAppStateAndValidators(forZeroHeight bool, jailAllowedAddrs []string) (genutil.ExportedApp, error)
 }
 
 // Scenario:

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,8 @@ func SetupTestInstance[T Tx, V SimulationApp[T]](`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`// InitializeChain sets up the blockchain with an initial state, validator set, and history using the provided genesis data.`
`169`		`-func (ti TestInstance[T]) InitializeChain(tb testing.TB,`
	`169`	`+func (ti TestInstance[T]) InitializeChain(`
	`170`	`+ tb testing.TB,`
`170`	`171`	`ctx context.Context,`
`171`	`172`	`chainID string,`
`172`	`173`	`genesisTimestamp time.Time,`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ import (`
`13`	`13`	`"github.com/stretchr/testify/require"`
`14`	`14`
`15`	`15`	`simtypes "github.com/cosmos/cosmos-sdk/types/simulation"`
`16`		`- v2 "github.com/cosmos/cosmos-sdk/x/genutil/v2"`
	`16`	`+ genutil "github.com/cosmos/cosmos-sdk/x/genutil/v2"`
`17`	`17`	`simcli "github.com/cosmos/cosmos-sdk/x/simulation/client/cli"`
`18`	`18`	`)`
`19`	`19`
`@@ -59,7 +59,7 @@ func TestAppStateDeterminism(t *testing.T) {`
`59`	`59`
`60`	`60`	`// ExportableApp defines an interface for exporting application state and validator set.`
`61`	`61`	`type ExportableApp interface {`
`62`		`- ExportAppStateAndValidators(forZeroHeight bool, jailAllowedAddrs []string) (v2.ExportedApp, error)`
	`62`	`+ ExportAppStateAndValidators(forZeroHeight bool, jailAllowedAddrs []string) (genutil.ExportedApp, error)`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`// Scenario:`