Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Invariants code from modules #22993

Closed
aljo242 opened this issue Dec 18, 2024 · 1 comment · Fixed by #22994
Closed

Remove Invariants code from modules #22993

aljo242 opened this issue Dec 18, 2024 · 1 comment · Fixed by #22994

Comments

@aljo242
Copy link
Collaborator

aljo242 commented Dec 18, 2024

Invariants and RegisterInvariants are still included in some modules, but these are not actually used with x/crisis already removed.

Remove the usages from the modules and deprecate the actual Invariant types and interfaces
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Dec 18, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Legacy Dec 18, 2024
@aljo242 aljo242 mentioned this issue Dec 18, 2024
Merged
12 tasks
@julienrbrt julienrbrt removed the needs-triage Issue that needs to be triaged label Dec 18, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Legacy Dec 20, 2024
@mergify mergify bot mentioned this issue Dec 20, 2024
Merged
12 tasks
@julienrbrt
Copy link
Member

Now that the PR has been backported, the deprecated functions can be deleted from main.

@technicallyty technicallyty mentioned this issue Jan 21, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Cosmos-SDK Legacy
Status: 🥳 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove invariants cosmos/cosmos-sdk
2 participants
@julienrbrt @aljo242