Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: Notification doesn't link to comment #1747

Open
1 task done
frank-connolly opened this issue Feb 11, 2025 · 1 comment
Open
1 task done

🐛 BUG: Notification doesn't link to comment #1747

frank-connolly opened this issue Feb 11, 2025 · 1 comment

Comments

@frank-connolly
Copy link

What went wrong? 🤔

This notification of a tagged message on a 'Welcome' post in the squad DevCraft does not link to the message and I cannot find the message in the comments when I go to the post:

Image

Having seen this before with my own squad I suspect the large number of comments on the welcome post means that they simply stop showing after a while and therefore cannot be linked to.

Expected Behavior

When I click a notification of being tagged in a comment - I should be taken to the comment.

Steps to Reproduce Issue

1. Be tagged in a comment on a post with a v high number of comments
2. Click on notification
3. Be brought to the post page. Not the comment, which you cannot find manually.

Solution Proposed

Comment limits (in terms of what is shown) make sense for performance and this seems to be a problem with the welcome posts as I'm guessing they are the main culprits. This is bad because as a squad owner, I am encourage by prompt to welcome a new member and add a comment they'll never see. So either, exempt 'welcome' posts from comment limits or provide a new way for squad owners to welcome new joiners

Screenshots

No response

Environment

No response

Browsers

Microsoft Edge

OS

Windows

Version of daily.dev

No response

Additional Context

Code of Conduct

  • I follow the conditions of this project.
@idoshamun
Copy link
Member

Hi @frank-connolly,

You're right. We have some issues supporting long discussions. We'll need to address it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants