Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSM forwarders can't be partially instantiated #32682

Closed
sjindel-google opened this issue Mar 27, 2018 · 3 comments
Closed

NSM forwarders can't be partially instantiated #32682

sjindel-google opened this issue Mar 27, 2018 · 3 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone

Comments

@sjindel-google
Copy link
Contributor

We should solve this when solving #32534.

@sjindel-google sjindel-google added P1 A high priority bug; for example, a single project is unusable or has many test failures area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Mar 27, 2018
@sjindel-google sjindel-google added this to the Dart2 Beta 3 milestone Mar 27, 2018
@sjindel-google sjindel-google self-assigned this Mar 27, 2018
@sjindel-google sjindel-google modified the milestones: Dart2 Beta 3, Dart2 Stable Apr 10, 2018
@a-siva
Copy link
Contributor

a-siva commented Apr 10, 2018

Chatted with @sjindel-google, this is related to a larger issue with instantiation of local and top level methods (#31665). This issue does not have a milestone associated with it. We should probably set it to 'dart2 beta 4' or 'Dart2 Stable' and adjust the related issues to the same milestone. We have moved this to 'Dart2 Stable' for now.

@sjindel-google
Copy link
Contributor Author

This is solved by https://dart-review.googlesource.com/c/sdk/+/53801, which moves handling of partial instantiation into the shared prologue builder.

@sjindel-google
Copy link
Contributor Author

This is actually still a problem:

$ echo >nsm_partial.dart <<EOF
class C {
  T foo<T>(T x);

  dynamic noSuchMethod(Invocation invoke) {
    print(invoke.typeArguments);
  }
}

void main() {
  var c = new C();
  int Function(int) k = c.foo;
  k(1);
}
EOF
$ pkg/vm/tool/dart2 nsm_partial.dart
[]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

2 participants